This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Backport the fix for dotnet/runtime issue 46529#28146
Merged
aik-jahoda merged 1 commit intodotnet:release/3.1from Mar 10, 2021
Merged
[release/3.1] Backport the fix for dotnet/runtime issue 46529#28146aik-jahoda merged 1 commit intodotnet:release/3.1from
aik-jahoda merged 1 commit intodotnet:release/3.1from
Conversation
… branch Fixes incorrect behavior a 64-bit long with shift of 32 or more combined with a cast to int
Author
|
Also consider this fix for 3,1 servicing PTAL |
jeffschwMSFT
approved these changes
Feb 16, 2021
Member
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Approved. Please get a cr and then we can take for approval
sandreenko
approved these changes
Feb 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5.0.x version of this change: dotnet/runtime#47741
Incorrect behavior a 64-bit long with shift of 32 or more combined with a cast to int
The JIT generates incorrect code for this code pattern:
(int) (X << C)where C >= 32 and
and X is anything with a potential side-effect and is 64-bit integer type
Customer Impact
Reported by customer who was migrating to .Net Core from the Desktop runtime.
Regression?
This is a regression that was introduced in the .Net 3.X timeframe by
#19899
Risk
Low
Fixes issue #47724