Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix Array.Copy regressions for large multidimensional arrays#27668

Merged
jkotas merged 3 commits intodotnet:masterfrom
jkotas:array-feedback
Nov 5, 2019
Merged

Fix Array.Copy regressions for large multidimensional arrays#27668
jkotas merged 3 commits intodotnet:masterfrom
jkotas:array-feedback

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Nov 4, 2019

No description provided.

@jkotas
Copy link
Member Author

jkotas commented Nov 4, 2019 

            Array a = new byte[2_000_000_000, 2];
            Array.Copy(a, 0, a, 1, 2);
            Console.WriteLine("Success");

Works in .NET Core 3.x. Throws exception in current master. Will add CoreFX test.

Thanks @GrabYourPitchforks for highlighting this.

This was referenced Nov 4, 2019
Merged
Merged
davidwrighton
davidwrighton approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member

@davidwrighton davidwrighton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious to know if this affects performance on 32bit platforms, but if it doesn't, the code looks good.

@jkotas
Copy link
Member Author

jkotas commented Nov 5, 2019

/azp run coreclr-ci

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 5, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas jkotas merged commit 5b3ac72 into dotnet:master Nov 5, 2019
@jkotas jkotas deleted the array-feedback branch November 5, 2019 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@GrabYourPitchforks GrabYourPitchforks Awaiting requested review from GrabYourPitchforks

2 more reviewers

@VSadov VSadov VSadov left review comments

@davidwrighton davidwrighton davidwrighton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jkotas @GrabYourPitchforks @VSadov @davidwrighton