Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Log the real command line in case the process is started as a service#24433

Merged
cshung merged 1 commit intodotnet:masterfrom
cshung:dev/andrewau/log-real-command-line
May 14, 2019
Merged

Log the real command line in case the process is started as a service#24433
cshung merged 1 commit intodotnet:masterfrom
cshung:dev/andrewau/log-real-command-line

Conversation

@cshung
Copy link
Copy Markdown

@cshung cshung commented May 6, 2019

Fixes #24454

@cshung cshung requested review from jorive, josalem, noahfalk and sywhang May 7, 2019 00:15
@cshung cshung changed the title [WIP] Log the real command line in case the process is started as a service Log the real command line in case the process is started as a service May 7, 2019
@noahfalk
Copy link
Copy Markdown
Member

noahfalk commented May 7, 2019

Is this fixing an issue that is filed somewhere or was this just some behavior you noticed and wanted to fix? It would be handy to have an issue that describes the bad state that is being fixed : )

@cshung cshung changed the title Log the real command line in case the process is started as a service [WIP] Log the real command line in case the process is started as a service May 7, 2019
@cshung
Copy link
Copy Markdown
Author

cshung commented May 7, 2019

Is this fixing an issue that is filed somewhere or was this just some behavior you noticed and wanted to fix? It would be handy to have an issue that describes the bad state that is being fixed : )

This fixes #24454.

@cshung cshung force-pushed the dev/andrewau/log-real-command-line branch from 2acd811 to 5ea03a7 Compare May 14, 2019 16:56
@cshung cshung changed the title [WIP] Log the real command line in case the process is started as a service Log the real command line in case the process is started as a service May 14, 2019
@cshung cshung merged commit 5f09000 into dotnet:master May 14, 2019
@cshung cshung deleted the dev/andrewau/log-real-command-line branch June 28, 2019 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Access violation - coreclr!EventPipeEventSource::SendProcessInfo+0x135

4 participants