This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Reflection: Fix FormatException when querying ParameterInfo.DefaultValue of optional (closed generic) enum parameter#17917
Merged
1 commit merged intodotnet:masterfrom May 8, 2018
Conversation
This is related to dbcfd2f, but about enums instead of `DateTime`. Given e.g. a generic method with a parameter `T arg = default(T)` where `T` is the generic type parameter, if that is instantiated with some enum as the generic type argument, then querying the default value of `arg` using `ParameterInfo.[Raw]DefaultValue` will throw a `FormatException`. (The use of generics means that the C# compiler always records a `null` constant in metadata, which isn't usually the case for enums.)
ghost
approved these changes
May 8, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to #17877, but about enums instead of
DateTime. This should fix https://github.com/dotnet/corefx/issues/29570.Given e.g. a generic method with a parameter
T arg = default(T)whereTis the generic type parameter, if that is instantiated with some enum as the generic type argument, then querying the default value ofargusingParameterInfo.[Raw]DefaultValuewill throw aFormatException.(The use of generics means that the C# compiler always records a
nullconstant in metadata, which isn't usually the case for enums.)/cc @atsushikan