This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Merged
Conversation
gkhanna79
reviewed
Apr 19, 2017
| <!-- The following are tests that fail on non-Windows, which we must not run when building against packages --> | ||
|
|
||
| <ItemGroup Condition="'$(XunitTestBinBase)' != '' and '$(BuildTestsAgainstPackages)' == 'true' and '$(RuntimeID)' != ''"> | ||
| <ItemGroup Condition="'$(XunitTestBinBase)' != '' and '$(BuildTestsAgainstPackages)' == 'true' and '$(TargetsWindows)' != 'true'"> |
Member
There was a problem hiding this comment.
So, we never specified RuntimeID?
Member
Author
There was a problem hiding this comment.
We do specify RuntimeID, it's just not available here anymore. Previously, if a runtimeID was passed, that meant we were building tests for non-windows; now we always pass a runtimeID when building against packages, and have an explicit variable (TargetsWindows) that determines if we're building tests for Windows or non-Windows - I just missed updating this file when I made that change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.