This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Stop treating test files as executable and fix encoding#11065
Merged
danmoseley merged 3 commits intodotnet:masterfrom Apr 19, 2017
yizhang82:encoding
Merged
Stop treating test files as executable and fix encoding#11065danmoseley merged 3 commits intodotnet:masterfrom yizhang82:encoding
danmoseley merged 3 commits intodotnet:masterfrom
yizhang82:encoding
Conversation
Member
|
@dotnet-bot test tizen armel cross debug build (https://github.com/dotnet/coreclr/issues/11069) |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out we accidentally made some test source code executable and git end up thinking they are executable files. Chmod -x fixed it. Also changing line ending and encoding to UTF-8 (only for one string marshaling test code that has unicode in it) to play nicer with git.