Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Honor disabled GC on Transitions during GC stress on Unix#11056

Merged
janvorli merged 1 commit intodotnet:masterfrom
parjong:fix/x86_GCStress_hang
Apr 19, 2017
Merged

Honor disabled GC on Transitions during GC stress on Unix#11056
janvorli merged 1 commit intodotnet:masterfrom
parjong:fix/x86_GCStress_hang

Conversation

@parjong
Copy link

@parjong parjong commented Apr 19, 2017

GC.Coverage.LargeObjectAlloc currently gets stuck in the presence of GC stress (level 3).

It seems that GC_ON_TRANSITIONS has logic to avoid this stuck, but this logic is enabled only for non-UNIX platforms (i.e. Windows).

This commit ports this logic in order to prevent hang during GC stress test.

@parjong parjong changed the title [WIP][x86/Linux] Do NOT run GC on Transition [x86/Linux] Do NOT run GC on Transition Apr 19, 2017
@parjong
Copy link
Author

parjong commented Apr 19, 2017

\CC @wateret

@parjong
Copy link
Author

parjong commented Apr 19, 2017

@janvorli Please take a look.

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli janvorli changed the title [x86/Linux] Do NOT run GC on Transition Honor disabled GC on Transitions during GC stress on Unix Apr 19, 2017
@janvorli
Copy link
Member

@parjong I took the liberty to modify the title of this PR to better reflect what it fixes.

@janvorli janvorli merged commit 0f6bc8b into dotnet:master Apr 19, 2017
@parjong parjong deleted the fix/x86_GCStress_hang branch April 19, 2017 09:02
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants