This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix incorrect test of structSize during struct promotion#11049
Merged
briansull merged 1 commit intodotnet:masterfrom Apr 19, 2017
Merged
Fix incorrect test of structSize during struct promotion#11049briansull merged 1 commit intodotnet:masterfrom
briansull merged 1 commit intodotnet:masterfrom
Conversation
Fixes the desktop test Crossgen NI and Ngen NI validation
|
@dotnet-bot test Tizen armel Cross Release Build |
|
@dotnet/jit-contrib |
BruceForstall
approved these changes
Apr 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the desktop test Crossgen NI and Ngen NI validation
For the Desktop build of crossgen FEATURE_SIMD is not defined so under desktop crossgen we would not struct promote a struct of size 32 (4 pointer sized fields).
For other builds FEATURE_SIMD is defined so we would allow struct promote of struct up to 63 bytes.
With this change we can struct promote a 64 byte struct with 4 SIMD fields.