This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[x86/Linux] Corretly pop args after unmanaged function call#11007
Merged
BruceForstall merged 2 commits intodotnet:masterfrom Apr 19, 2017
Merged
[x86/Linux] Corretly pop args after unmanaged function call#11007BruceForstall merged 2 commits intodotnet:masterfrom
BruceForstall merged 2 commits intodotnet:masterfrom
Conversation
Member
|
retest |
Author
|
@janvorli @BruceForstall Please take a look. |
Member
|
@parjong I'll let @BruceForstall review this. I don't understand JIT well enough to understand why "CodeGen::genCallInstruction, call->callSig may be incorrect for direct unmanaged calls". |
Author
|
@janvorli I notice that this PR is solely about JIT only after your comment. Sorry for disturbing you. |
|
cc @dotnet/jit-contrib |
BruceForstall
approved these changes
Apr 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CodeGen::genCallInstruction, call->callSig may be incorrect for direct unmanaged calls, which results in #11006.
This commit suppresses calling convention inference for unmanaged calls to fix #11006.
This commit also resolves signature mismatch in HFA tests. hfa_interop.cs declares each native function explicitly as stdcall. Unfortunately, hfa_native.h (and hfa_native.cpp) does not specify calling convention, and thus the corresponding functions use cdecl.