Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

IBC: Disable -partialNGEN -minify for SPC.dll#10950

Merged
dpodder merged 6 commits intodotnet:masterfrom
dpodder:ibcmerge-fixes
Apr 19, 2017
Merged

IBC: Disable -partialNGEN -minify for SPC.dll#10950
dpodder merged 6 commits intodotnet:masterfrom
dpodder:ibcmerge-fixes

Conversation

@dpodder
Copy link

@dpodder dpodder commented Apr 13, 2017

This PR adds some fixes around the use of IBCMerge in CoreCLR, along with a BuildTools patch (which the fixes are dependent upon):

  • don't restore the default optdata package through BuildTools
  • don't use partial ngen by default in CoreCLR for SPC.dll

Daniel Podder added 2 commits April 13, 2017 15:26
* don't restore the default optdata package from BuildTools
* don't use partial ngen by default in CoreCLR for SPC.dll
@dpodder dpodder changed the title Update BuildTools to fix IbcMerge IBC: Disable -partialNGEN -minify for SPC.dll Apr 14, 2017
@dpodder
Copy link
Author

dpodder commented Apr 14, 2017

@chcosta @wtgodbe PTAL
/cc: @dagood

FYI, I tried taking a BuildTools update first, but that resulted in various failures in two buckets:

Once this is merged I'll open an Issue to track removing the override after we update BuildTools past the minimum required version (1.0.27-prerelease-01513-01)

@dpodder
Copy link
Author

dpodder commented Apr 19, 2017

/ping: @chcosta @wtgodbe

@wtgodbe
Copy link
Member

wtgodbe commented Apr 19, 2017

Sorry, missed this earlier. LGTM

@dpodder
Copy link
Author

dpodder commented Apr 19, 2017

Thanks!

@dpodder dpodder merged commit c6506d7 into dotnet:master Apr 19, 2017
@dpodder dpodder deleted the ibcmerge-fixes branch April 19, 2017 19:09
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants