This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Get rid of "#if FEATURE_RANDOMIZED_STRING_HASHING" in shared partition.#10851
Conversation
Since CoreCLR defines it (for now) and CoreRT doesn't, let's not have "#if's" on this in shared code. It just creates confusion. The only ones are in StringComparer.cs and fortunately, they are quite expendable as... 1. It's only purpose is serialize Hashtables and Dictionaries in a way that CLR 1.1 can deserialize them. We don't care about that in .NET Core. 2. In CoreCLR as of today, this infrastructure is not changing the serialization blob one iota since all the GetEqualityComparerForSerialization() methods return "this." So this removes the appearance of downgrading the comparers to non-randomized versions for serialization purposes (and yes, we could go on and remove all the other "let's do it for Everett and RTM" stuff in Hashtable.cs, but I want to keep this PR on topic. Hashtable.cs is not going to be imported into CoreRT so it's low priority for me.)
jkotas
approved these changes
Apr 10, 2017
Author
|
@dotnet-bot test Tizen armel Cross Debug Build |
1 similar comment
Author
|
@dotnet-bot test Tizen armel Cross Debug Build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since CoreCLR defines it (for now) and CoreRT doesn't, let's not have
"#if's" on this in shared code. It just creates confusion.
The only ones are in StringComparer.cs and fortunately, they are quite
expendable as...
It's only purpose is serialize Hashtables and Dictionaries in
a way that CLR 1.1 can deserialize them. We don't care about that in
.NET Core.
In CoreCLR as of today, this infrastructure is not changing the serialization
blob one iota since all the GetEqualityComparerForSerialization() methods
return "this."
So this removes the appearance of downgrading the comparers to non-randomized
versions for serialization purposes (and yes, we could go on and remove
all the other "let's do it for Everett and RTM" stuff in Hashtable.cs, but
I want to keep this PR on topic. Hashtable.cs is not going to be imported
into CoreRT so it's low priority for me.)