Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[Linux][GDB-JIT] Fix incorrect displaying of large structures in lldb.#10797

Merged
janvorli merged 1 commit intodotnet:masterfrom
Buyduck:fix-dwarf-class-size-field
Apr 10, 2017
Merged

[Linux][GDB-JIT] Fix incorrect displaying of large structures in lldb.#10797
janvorli merged 1 commit intodotnet:masterfrom
Buyduck:fix-dwarf-class-size-field

Conversation

@Buyduck
Copy link

@Buyduck Buyduck commented Apr 7, 2017

This PR increases size of DWARF field, which contains size of 'ClassType' variables.
Without this fix lldb showing wrong field values for structures with size > 256 bytes.

@mikem8361, @janvorli PTAL

cc @Dmitri-Botcharnikov @chunseoklee @seanshpark @lucenticus @kvochko @ayuckhulk

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@lucenticus
Copy link

@dotnet-bot test OSX10.12 x64 Checked Build and Test please

@janvorli janvorli merged commit 468d9a3 into dotnet:master Apr 10, 2017
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants