This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Handle SIGTERM on OSX#10723
Merged
danmoseley merged 2 commits intodotnet:masterfrom Apr 8, 2017
kouvel:SigTerm
Merged
Conversation
janvorli
reviewed
Apr 5, 2017
Member
janvorli
left a comment
There was a problem hiding this comment.
LGTM modulo the two nits. Thank you!
src/pal/src/exception/signal.cpp
Outdated
| static void sigint_handler(int code, siginfo_t *siginfo, void *context); | ||
| static void sigquit_handler(int code, siginfo_t *siginfo, void *context); | ||
| #endif // !HAVE_MACH_EXCEPTIONS | ||
| static void sigterm_handler(int code, siginfo_t *siginfo, void *context); |
Member
There was a problem hiding this comment.
A nit - could you please move this line above all of the handler declarations? Then you can use single #if !HAVE_MACH_EXCEPTIONS
src/pal/src/exception/signal.cpp
Outdated
| #endif // !HAVE_MACH_EXCEPTIONS | ||
| struct sigaction g_previous_sigterm; | ||
|
|
||
| static bool registered_sigterm_handler = false; |
Member
There was a problem hiding this comment.
A nit - similar to what I've said above, could you please move the two variables above all the struct sigaction xxxx declarations above and use single #if !HAVE_MACH_EXCEPTIONS?
Author
|
@dotnet-bot test OSX10.12 x64 Checked Build and Test |
2 similar comments
Author
|
@dotnet-bot test OSX10.12 x64 Checked Build and Test |
Author
|
@dotnet-bot test OSX10.12 x64 Checked Build and Test |
added 2 commits
April 6, 2017 11:24
Fixes #7394
Member
|
@dotnet-bot test OSX10.12 x64 Checked Build and Test (network) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7394