-
Notifications
You must be signed in to change notification settings - Fork 217
Add auto dependency flow repo API #3320
Conversation
dagood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of the changes for CLI 2.0.0, I don't understand the DisableImplicitAssetTargetFallback and NoWarn, but the rest make sense. Dependency flow implementation looks good other than NETStandardLibraryVersion.
dependencies.props
Outdated
| <NETStandardVersion>2.0.0</NETStandardVersion> | ||
| <DiaSymReaderNativeVersion>1.4.1</DiaSymReaderNativeVersion> | ||
| <WcfVersion>4.4.0-preview3-25503-01</WcfVersion> | ||
| <NETStandardLibraryVersion>2.0.0</NETStandardLibraryVersion> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This is a bit complicated, but I'll try to explain. Back in the There are tests for the Moving to the 2.0.0 SDK, NuGet no longer can restore these old packages by default. So we need to add these properties to these projects in order to keep the old restore behavior. I didn't want to nuke these tests in this change. I've logged https://github.com/dotnet/core-setup/issues/3323 for us to look into whether deleting these tests is the right thing to do or not. |
dagood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation, LGTM after NETStandardLibraryPackageVersion.
weshaggard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable.
8120d9b to
f44d69d
Compare
I first needed to fix the build for the new 2.0.0 RTM version of the .NET Core SDK.
The 2nd commit implements the auto-dependency flow.