fix hashes #10086
Merged
fix hashes #10086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 10, 2025 19:08
rbhanda
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://github.com/dotnet/release/issues/1360.
Based on a report from https://dev.azure.com/dnceng/internal/_build/results?buildId=2790357&view=logs&j=a04ccd0e-f300-5bd3-9bff-a825d84d94c7&t=4286beb4-0319-531f-3602-b10bb7d12c2a
and its log entries containing a phrase "Hash mismatch for", we revealed mismatches between Sha512 hash values contained in release files and actual Sha512 hash values computed during the validation steps in the pipeline.
We think that we can consider the files pointed by the release files as having correct content, as they are from older dotnet versions and hence already used by customers. Hence we are correcting the hash values in release files.
These fixes are based on following extracted lines from the pipeline report:
hash mismatch report - invalid and valid hash.txt
which in release files are sections mentioning release channels reported in an extract (from the same log)
hash mismatch report - channels.txt
Testing:
With this branch (https://github.com/ondrejsmid/dotnet-core/tree/dev/ondrejsmid/fix-hashes) there were no invalid hashes reported anymore (No lines having "Hash mismatch for"):
https://dev.azure.com/dnceng/internal/_build/results?buildId=2791050&view=logs&j=a04ccd0e-f300-5bd3-9bff-a825d84d94c7&t=4286beb4-0319-531f-3602-b10bb7d12c2a