Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Determine FX dir using FX_DEPS_FILE#2617

Merged
schellap merged 1 commit intodotnet:rel/1.0.0from
schellap:fx-deps-file
Apr 21, 2016
Merged

Determine FX dir using FX_DEPS_FILE#2617
schellap merged 1 commit intodotnet:rel/1.0.0from
schellap:fx-deps-file

Conversation

@schellap
Copy link
Copy Markdown

@schellap schellap commented Apr 21, 2016

This change is Reviewable

@schellap
Copy link
Copy Markdown
Author

schellap commented Apr 21, 2016

@brthor, PTAL.

@schellap
Copy link
Copy Markdown
Author

schellap commented Apr 21, 2016

@dotnet-bot test Windows_NT x64 Release Build please

schellap
schellap reviewed Apr 21, 2016
View reviewed changes
src/Microsoft.DotNet.Cli.Utils/Muxer.cs Outdated
var appBase = new FileInfo(typeof(object).GetTypeInfo().Assembly.Location);
var muxerDir = appBase.Directory?.Parent?.Parent?.Parent;
var fxDepsFile = GetDataFromAppDomain("FX_DEPS_FILE");
if (fxDepsFile == null)

This comment was marked as spam.

Sign in to view

@schellap schellap closed this Apr 21, 2016
@schellap schellap reopened this Apr 21, 2016
@schellap
Copy link
Copy Markdown
Author

schellap commented Apr 21, 2016

Fixes #2489

@schellap
Copy link
Copy Markdown
Author

schellap commented Apr 21, 2016

@dotnet-bot test Windows_NT x86 Debug Build
Build please

@schellap
Copy link
Copy Markdown
Author

schellap commented Apr 21, 2016

@piotrpMSFT, this is the last RC bug. I am going to update CLI builds to use a known Muxer next.

@schellap
Copy link
Copy Markdown
Author

schellap commented Apr 21, 2016

@Sridhar-MS could you PTAL?

Sridhar-MS
Sridhar-MS reviewed Apr 21, 2016
View reviewed changes
src/Microsoft.DotNet.Cli.Utils/Muxer.cs
{
var appDomainType = typeof(object).GetTypeInfo().Assembly?.GetType("System.AppDomain");
var currentDomain = appDomainType?.GetProperty("CurrentDomain")?.GetValue(null);
var deps = appDomainType?.GetMethod("GetData")?.Invoke(currentDomain, new[] { propertyName });

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@Sridhar-MS
Copy link
Copy Markdown

Sridhar-MS commented Apr 21, 2016

LGTM modulo one comment

Sridhar-MS
Sridhar-MS reviewed Apr 21, 2016
View reviewed changes
src/Microsoft.DotNet.Cli.Utils/Muxer.cs
{
var appBase = new FileInfo(typeof(object).GetTypeInfo().Assembly.Location);
var muxerDir = appBase.Directory?.Parent?.Parent?.Parent;
var fxDepsFile = GetDataFromAppDomain("FX_DEPS_FILE");

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@schellap schellap merged commit 3d8cbba into dotnet:rel/1.0.0 Apr 21, 2016
@schellap schellap deleted the fx-deps-file branch April 21, 2016 20:49
@natemcmaster natemcmaster mentioned this pull request Jan 31, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@schellap @Sridhar-MS @brthor @leecow @dnfclas