Enable source-build pre-built detection #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I will add SBRP subscription after this is merged. |
MichaelSimons
approved these changes
Apr 18, 2023
eng/Version.Details.xml
Outdated
| <Sha>1177b37e60c7271ab461098aefbdd03edc15b90d</Sha> | ||
| <SourceBuild RepoName="arcade" ManagedOnly="true" /> | ||
| </Dependency> | ||
| <Dependency Name="Microsoft.SourceLink.GitHub" Version="1.2.0-beta-23172-02" CoherentParentDependency="Microsoft.DotNet.Arcade.Sdk"> |
Member
There was a problem hiding this comment.
Looks like a potential version mismatch given the prebuilts reported in CI.
Member
Author
There was a problem hiding this comment.
Will check - I used the version that matches prebuilts reported in this repo's source-build - in my local build.
Member
Author
There was a problem hiding this comment.
Looks like a potential version mismatch given the prebuilts reported in CI.
Fixed with 901c0f9
This was caused by Arcade update that happened 30 minutes ago, after my local build, but before PR was created - the timing...
77ee3ec to
901c0f9
Compare
mmitche
approved these changes
Apr 18, 2023
Member
Author
|
Created subscription for SBRP repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/runtime#84985
Enabling per-repo source-build to detect prebuilt packages.