Fixing issues in version.h that were causing file description changes.#669
Conversation
|
It isn't entirely clear to me how this fixes the issue in coreclr. Did we have actual projects with AssemblyName=build? |
|
No, the reason why the name was "build" was because the version.h file is only generated once per build, and we do it by calling into the project |
|
What we were doing previous to this change, was to override the description that the native projects already defined. This is an example of how native projects define their own file description names. |
|
OK so the only think you are force overriding now is the version then. LGTM |
|
Exactly, only the version will be overridden now. |
When we added versioning to native components to coreclr repo, we broke the File Description of the assemblies when they had one defined. This changes will only force the versions to be changed, everything else will stay the same if it is already defined.
Once this is merged and consumed by coreclr, it will fix dotnet/coreclr#4367
cc: @weshaggard
FYI: @AndyAyersMS @mikedn