Skip to content

[release/10.0] Fix bad merge to event numbers#65392

Merged
wtgodbe merged 2 commits intorelease/10.0from
danegsta/eventNumber
Feb 12, 2026
Merged

[release/10.0] Fix bad merge to event numbers#65392
wtgodbe merged 2 commits intorelease/10.0from
danegsta/eventNumber

Conversation

@danegsta
Copy link
Member

Correct event version numbers

Three event version numbers were incorrect after a merge into release/10.0

Description

This causes errors during certificate trust on WSL and Ubuntu GitHub actions runners (which are apparently WSL based).

Fixes #65390, #65391

@danegsta danegsta added the Servicing-consider Shiproom approval is required for the issue label Feb 11, 2026
Copilot AI review requested due to automatic review settings February 11, 2026 01:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an incorrect merge in the Dotnet-dev-certs EventSource that caused runtime failures when trusting dev certs on WSL/Ubuntu runners by aligning WriteEvent(...) calls with their [Event(...)] IDs.

Changes:

  • Correct WriteEvent event IDs for WslWindowsTrustSucceeded, WslWindowsTrustFailed, and WslWindowsTrustException.
  • Minor whitespace cleanup around the affected event definitions.

@danegsta danegsta added feature-devcerts and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Feb 11, 2026
@github-actions github-actions bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Feb 11, 2026
@DamianEdwards DamianEdwards added area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Feb 11, 2026
@danegsta
Copy link
Member Author

@DamianEdwards and @eerhardt I had to manually resolve merge conflicts since #65341 also just merged. I very carefully double checked the event version numbers are still correct, but please take a look again as well.

@danegsta danegsta added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Feb 12, 2026
@danegsta
Copy link
Member Author

Tactics approved via email.

@danegsta danegsta closed this Feb 12, 2026
@danegsta danegsta reopened this Feb 12, 2026
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0.4 milestone Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI feature-devcerts Servicing-approved Shiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants