Conversation
Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
|
@halter73 @BrennanConroy These properties have been experimental since .NET 7. We're not doing any work here, and the properties seem stable. I think it's fine to remove the preview attribute. |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the [RequiresPreviewFeatures] attribute from four properties in QuicTransportOptions, marking them as stable API. These properties have already been shipped in the public API surface.
- Removes preview feature restrictions from QUIC transport stream and buffer configuration properties
- Removes the now-unused
using System.Runtime.Versioning;directive
halter73
left a comment
There was a problem hiding this comment.
Do we have anything else HTTP/3 related that still has [RequiresPreviewFeatures] other than IWebTransportSession? Should we remove it for that too?
No, leave it there. Web transport was an intern project and needs a lot of work. I wonder if it should be removed. |
Remove RequiresPreviewFeatures from QuicTransportOptions properties
Remove preview feature requirements from QuicTransportOptions properties
Description
Removes
[RequiresPreviewFeatures]attribute from four properties inQuicTransportOptions:MaxBidirectionalStreamCountMaxUnidirectionalStreamCountMaxReadBufferSizeMaxWriteBufferSizeThese properties are already in
PublicAPI.Shipped.txtand are now stable for general use.Also removes the now-unused
using System.Runtime.Versioning;directive.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.