Conversation
…esCancellationTokenThatSignalsWhenRevalidationLoopIsBeingDiscarded
3 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR unquarantines a previously flaky test by removing the [QuarantinedTest] attribute, indicating the test has been stable for 30 days and is now safe to run in the regular test suite.
- Removes quarantine attribute from a specific test method
- Re-enables the test in the regular CI pipeline
ilonatommy
approved these changes
Aug 25, 2025
Member
ilonatommy
left a comment
There was a problem hiding this comment.
Are we able to pinpoint the change that could have fixed it?
Member
Author
Nope. Based on a brief investigation, I could not find any change that we could point to as the reason that the test has been fixed (made deterministic). None of the directly related sources have changed since the test got quarantined. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test has not failed in the last 30 days (https://dev.azure.com/dnceng-public/public/_test/analytics?definitionId=84&contextType=build).
When running all tests from the test class locally in a loop, 300/300 runs succeeded.
Fixes #60472