[release/8.0] Dispose the certificate chain elements with the chain#62994
Merged
wtgodbe merged 1 commit intorelease/8.0from Aug 5, 2025
Merged
[release/8.0] Dispose the certificate chain elements with the chain#62994wtgodbe merged 1 commit intorelease/8.0from
wtgodbe merged 1 commit intorelease/8.0from
Conversation
* Dispose the certificate chain elements with the chain * Fix the missing brace * Remove snarky comment. * Add another choice using based on review feedback * Styling fixes --------- Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a resource management issue by ensuring that X509Certificate2 objects in certificate chains are properly disposed. The fix prevents potential memory leaks by manually disposing all certificate chain elements before disposing the chain itself.
Key changes:
- Replace
usingdeclarations with try-finally blocks for X509Chain disposal - Add manual disposal of certificate chain elements before disposing the chain
- Fix a syntax error (semicolon to closing brace)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Shared/CertificateGeneration/UnixCertificateManager.cs | Adds proper disposal pattern for X509Chain and its elements, fixes syntax error |
| src/Security/Authentication/Certificate/src/CertificateAuthenticationHandler.cs | Implements the same disposal pattern for certificate validation |
Comments suppressed due to low confidence (1)
src/Shared/CertificateGeneration/UnixCertificateManager.cs:178
- This appears to be fixing a syntax error where a semicolon was incorrectly used instead of a closing brace.
}
halter73
approved these changes
Jul 31, 2025
This was referenced Sep 9, 2025
Closed
This was referenced Feb 24, 2026
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 3, 2026
Closed
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #62531 to release/8.0
Dispose the certificate chain elements with the chain
Fixes an issue in certificate authentication where certificates within a certificate chain were not getting directly disposed.
Description
Failing to dispose each certificate within an X509 chain can create significant GC pressure for applications that frequently perform TLS handshakes. While the previous disposal logic only disposed the
X509Chainitself, this PR updates the logic to first enumerate and dispose each certificate in the chain directly.Customer Impact
The original contribution was from a customer who determined that this issue has a severe negative performance impact on their large scale web application. See #62531 (comment).
Regression?
Risk
The change is straightforward and follows an established disposal pattern.
Verification
Packaging changes reviewed?