feat: support tls client hello bytes callback in Kestrel#61631
Merged
DeagleGross merged 20 commits intodotnet:mainfrom May 1, 2025
DeagleGross:dmkorolev/kestrel-tls
Merged
feat: support tls client hello bytes callback in Kestrel#61631DeagleGross merged 20 commits intodotnet:mainfrom DeagleGross:dmkorolev/kestrel-tls
DeagleGross merged 20 commits intodotnet:mainfrom
DeagleGross:dmkorolev/kestrel-tls
Conversation
gfoidl
reviewed
Apr 23, 2025
src/Servers/Kestrel/Core/src/Middleware/TlsListenerMiddleware.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/Core/src/Middleware/TlsListenerMiddleware.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/Core/src/Middleware/TlsListenerMiddleware.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/Core/src/Middleware/TlsListenerMiddleware.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/Core/src/Middleware/TlsListenerMiddleware.cs
Outdated
Show resolved
Hide resolved
gfoidl
reviewed
Apr 23, 2025
src/Servers/Kestrel/Core/src/Middleware/TlsListenerMiddleware.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/Core/src/Middleware/TlsListenerMiddleware.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/test/InMemory.FunctionalTests/TlsListenerMiddlewareTests.cs
Show resolved
Hide resolved
src/Servers/Kestrel/test/InMemory.FunctionalTests/TlsListenerMiddlewareTests.Units.cs
Show resolved
Hide resolved
3 tasks
src/Servers/Kestrel/Core/src/Middleware/TlsListenerMiddleware.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/Core/src/Middleware/TlsListenerMiddleware.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/test/InMemory.FunctionalTests/TlsListenerMiddlewareTests.Units.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/test/InMemory.FunctionalTests/TlsListenerMiddlewareTests.Units.cs
Show resolved
Hide resolved
… duplicate registration
Member
Author
|
add tests for SSL 2.0 and SSL 3.0 |
Member
Author
done |
src/Servers/Kestrel/test/InMemory.FunctionalTests/TestTransport/InMemoryTransportConnection.cs
Outdated
Show resolved
Hide resolved
BrennanConroy
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supporting TLS Client Hello callback in Kestrel
HTTP.SYS contribution was done in this PR
Description
Adding a new property to
HttpsConnectionAdapterOptions-TlsClientHelloBytesCallback(added to public API).It allows to subscribe to the TLS client hello message parsed from the
ConnectionContext.Transport.Input:If property
HttpsConnectionAdapterOptions.TlsClientHelloBytesCallbackis set (not null), then new middleware is added beforeHttpsConnectionMiddleware.The implementation is doing the following:
Fixes #60805