Add support for setting security attributes on Http.Sys RequestQueue#61325
Merged
BrennanConroy merged 5 commits intomainfrom Apr 28, 2025
Merged
Add support for setting security attributes on Http.Sys RequestQueue#61325BrennanConroy merged 5 commits intomainfrom
BrennanConroy merged 5 commits intomainfrom
Conversation
BrennanConroy
commented
Apr 4, 2025
10ebaa7 to
cabcc2f
Compare
|
|
||
| _disposed = true; | ||
|
|
||
| PInvoke.HttpCloseRequestQueue(Handle); |
Contributor
There was a problem hiding this comment.
Seems like a reasonable change but unrelated to this PR. Drive-by bug fix or is it related somehow?
Member
Author
There was a problem hiding this comment.
Drive-by, was just reading the docs for HttpCreateRequestQueue to make sure I was doing the correct thing with the security attribute and noticed it said you should close the queue handle with HttpCloseRequestQueue.
captainsafia
approved these changes
Apr 28, 2025
Contributor
captainsafia
left a comment
There was a problem hiding this comment.
Left a few questions inline but LGTM overall!
| HttpCancelHttpRequest | ||
| HttpCloseServerSession | ||
| HttpCloseUrlGroup | ||
| HttpCloseRequestQueue |
Contributor
There was a problem hiding this comment.
What's this file for?
Member
Author
There was a problem hiding this comment.
It's how the cswin32 source generator decides what methods to create PInvokes for
https://microsoft.github.io/CsWin32/docs/getting-started.html
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61084