Remove unnecessary newline at the end of the webapiaot csproj#61302
Merged
wtgodbe merged 1 commit intodotnet:mainfrom Apr 11, 2025
Merged
Conversation
This brings the template in line with the `dotnet new webapi` one, where there is no lingering newline at the end of the csproj.
3 tasks
Contributor
Author
|
Hi @captainsafia ! Perhaps you can have a quick peek at this 1LOC PR change :) |
captainsafia
approved these changes
Apr 11, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
The failing tests seems to have nothing to do with my changes. I think it's simply a flaky test? I think a new |
Contributor
|
@wtgodbe Any chance you can use your powers to merge this whitespace change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unnecessary newline at the end of the webapiaot csproj
This PR removes a lingering newline at the end of the webapiaot csproj
Description
In #60337 I added OpenAPI support to the
dotnet new webapiaottemplate. This adds theMicrosoft.AspNetCore.OpenApipackage by default.I just tested this locally by installing the
preview4build. I saw that the.csprojhas an extra newline at the end, before the</project>tag. Thedotnet new webapitemplate doesn't have this, which means this is a bit inconsistentI removed this extra newline in this PR to ensure both templates behave the same way.
Fixes #59564