Limit types that get converted to null for empty/null input in NullableConverter#60498
Merged
oroztocil merged 2 commits intodotnet:mainfrom Feb 20, 2025
Conversation
5a5a95c to
3dd098b
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Components/Endpoints/test/FormMapping/Converters/NullableConverterTests.cs:210
- Consider adding an assertion that verifies result is null when conversion fails, to make the expected behavior more explicit.
var returnValue = nullableConverter.TryConvertValue(ref reader, "bad value", out var result);
javiercn
approved these changes
Feb 20, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limits the nullable types for which empty string or null input gets converted to
nullinNullableConverter. After the change this only happens for types that either haveTypeCode != TypeCode.Objector belong to a set of special supported types (currentlyDateOnly,TimeOnly,DateTimeOffset).Other types get processed by the respective non-nullable converter as was the case before #52499. In particular, types implementing
IParsable(with the exception of the types mentioned above) get converted using theirTryParsemethod (viaParsableConverter) which means they can provide custom implementation for handling empty/null inputs.