Fix: OpenAPI Schema Handling For Nullable Collection Types#60460
Merged
captainsafia merged 1 commit intodotnet:mainfrom Feb 18, 2025
xC0dex:fix-openapi-nullable-collection
Merged
Fix: OpenAPI Schema Handling For Nullable Collection Types#60460captainsafia merged 1 commit intodotnet:mainfrom xC0dex:fix-openapi-nullable-collection
captainsafia merged 1 commit intodotnet:mainfrom
xC0dex:fix-openapi-nullable-collection
Conversation
captainsafia
approved these changes
Feb 18, 2025
Contributor
captainsafia
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the fix.
|
Hi any chance to bring this bugfix also in package version 9.x ? |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: OpenAPI Schema Handling For Nullable Collection Types
You've included inline docs for your change, where applicable.Description
This PR updates the handling of nullable collections in OpenAPI schemas when applying validation attributes like
[Length],[MinLength]or[MaxLength]. Previously, if a collection was nullable, it caused an exception with the message The node must be of type 'JsonValue'.This issue is now fixed by checking the type properly. Additionally, tests have been added to cover this case.
Fixes #59428