Avoid IISHttpServer close race on construction#60399
Merged
BrennanConroy merged 4 commits intomainfrom Feb 20, 2025
Merged
Conversation
Open
3 tasks
Member
|
I'm not seeing any changes to callbacks, but I'm not really across this part of the codebase, just trying to interpret what you are doing here so I can approve if I can. |
Member
Author
Member
|
Ah I missed what you meant, I thought you meant you had moved registration of the callbacks as well but you just made sure the native call was after callbacks. |
mitchdenny
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid throwing in IISHttpServer.ctor by moving the native call into
IServer.StartAsync, also setting up native to managed callbacks before doing anything else so that if there are any errors native can still tell managed it's shutting down.The
NativeMethods.HttpGetApplicationProperties()call can throw if the native side is shutting down while the managed side is starting up.Quarantine test tracking: #60482