Enhance Lockout Functionality: Add Test for AccessFailedAsync Incrementing Count#60350
Enhance Lockout Functionality: Add Test for AccessFailedAsync Incrementing Count#60350shethaadit wants to merge 11 commits intodotnet:mainfrom
Conversation
|
Thanks for your PR, @shethaadit. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/Identity/Extensions.Core/src/UserManager.cs:1833
- Add a test to cover the scenario where Options.Lockout.DefaultLockoutTimeSpan is TimeSpan.MaxValue to ensure the lockout end date is set correctly.
if (Options.Lockout.DefaultLockoutTimeSpan == TimeSpan.MaxValue)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Rick-Anderson
left a comment
There was a problem hiding this comment.
@tdykstra review my suggestions please.
Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
|
Hi @Rick-Anderson, @tdykstra, I committed changes according to suggestions. Could you please review again? Can you also help fixing build issue? Seems something from platform side. .dotnet\sdk\10.0.100-preview.2.25102.3\NuGet.targets(175,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Cannot create a file when that file already exists. |
…shethaadit/FixBug60181
…t/aspnetcore into shethaadit/FixBug60181
Hi @Rick-Anderson, @tdykstra, can you please review? |
Rick-Anderson
left a comment
There was a problem hiding this comment.
Thanks for accepting my suggestions. As mentioned previously, I'm only approving the comments. I'm not able to review the code.
…shethaadit/FixBug60181
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
Enhance Lockout Functionality: Add Test for
AccessFailedAsyncIncrementing CountPR Description:
This PR enhances the test coverage of the lockout functionality in
UserManagerTest.csby adding a new test case:AccessFailedAsync_IncrementsAccessFailedCountAccessFailedAsynccorrectly increments the access failed count for a user.Mock<IUserLockoutStore<PocoUser>>to simulate the behavior of the underlying store.This change improves reliability by validating that lockout mechanisms work as expected, aligning with best practices in identity management.
Testing:
Fixes #60181