Ensure that the hub client proxy generator correctly processes both explicit and inferred generic type arguments#55862
Conversation
Update .NET SDK to version 9.0.100-preview.5.24269.5. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…iew.5.24269.5 Update .NET SDK to 9.0.100-preview.5.24269.5
… class for both GenericNameSyntax and IdentifierNameSyntax
…ric and inferred cases are handled.
src/SignalR/clients/csharp/Client.SourceGenerator/src/HubClientProxyGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
…or-correctly-processes-both-explicit-and-inferred-generic-type-arguments
…sses-both-explicit-and-inferred-generic-type-arguments' of https://github.com/mattyleslie/aspnetcore into ensure-that-the-HubClientProxyGenerator-correctly-processes-both-explicit-and-inferred-generic-type-arguments
…d and explicit generic type arguments.
…or-correctly-processes-both-explicit-and-inferred-generic-type-arguments
|
Hey @BrennanConroy, I added tests to |
|
I think VS has some weird behavior with source generators being referenced via project reference. Sometimes building via the command line first might help. But the issue in the PR looks like you just need to make |
…sses-both-explicit-and-inferred-generic-type-arguments' of https://github.com/mattyleslie/aspnetcore into ensure-that-the-HubClientProxyGenerator-correctly-processes-both-explicit-and-inferred-generic-type-arguments
…or-correctly-processes-both-explicit-and-inferred-generic-type-arguments
Fix HubClientProxyGenerator to Handle Inferred Generic Type Arguments
Issue:
The
HubClientProxyGeneratorwas not generating proxy code for methods using inferred generic type arguments. This was because the initial syntax node filter only considered methods with explicit generic types.Solution:
Updated the syntax node filter to include both explicit and inferred generic type arguments by changing the filter condition to
SimpleNameSyntax. This ensures that all relevant methods are processed for proxy generation.Fixes #43510