Skip to content

Fix x86 folder contents in ARM64 Windows Server Hosting Bundle installer#47124

Closed
lextm wants to merge 1 commit intodotnet:mainfrom
lextm:patch-1
Closed

Fix x86 folder contents in ARM64 Windows Server Hosting Bundle installer#47124
lextm wants to merge 1 commit intodotnet:mainfrom
lextm:patch-1

Conversation

@lextm
Copy link
Copy Markdown
Contributor

@lextm lextm commented Mar 10, 2023

Fix x86 folder contents in Windows 11 ARM64 Server Hosting Bundle installer

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Consume x86 binaries in ARM64 Windows Server Hosting Bundle installer to fix x86 application pool crash. Resolve one of the two problems reported in #47115.

Description

Before this change, the ARM64 installer picks up the pure ARM64 binaries and installs into Program Files (x86), so that x86 application pool cannot load them and simply crashes. After this change, the installer switches to install x86 binaries into Program Files (x86) folder, so that x86 application pools won't crash.

Fixes part of #47115 (but x64 application pool crash is not resolved by this pull request).

@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member labels Mar 10, 2023
@ghost
Copy link
Copy Markdown

ghost commented Mar 10, 2023

Thanks for your PR, @lextm. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@ghost
Copy link
Copy Markdown

ghost commented Mar 17, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please leave an /azp run comment here to rerun the CI pipeline and confirm success before merging the change.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Mar 17, 2023
@lextm
Copy link
Copy Markdown
Contributor Author

lextm commented Mar 19, 2023

All required changes are now committed to #47290. Close this one as it is no longer needed.

@lextm lextm closed this Mar 19, 2023
@lextm lextm deleted the patch-1 branch April 15, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant