Update project template precedence values#44479
Merged
dougbu merged 1 commit intorelease/7.0from Oct 12, 2022
Merged
Conversation
wtgodbe
reviewed
Oct 11, 2022
src/ProjectTemplates/Web.Client.ItemTemplates/content/Scss/.template.config/template.json
Show resolved
Hide resolved
wtgodbe
approved these changes
Oct 11, 2022
|
Hi @MackinnonBuck. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
mkArtakMSFT
approved these changes
Oct 11, 2022
Member
Author
|
UPDATE: There is some discussion offline about the general direction we should take with the template configuration. Let's hold off merging until that conversation concludes. |
Contributor
|
I think we're ready to merge this. Agreed @MackinnonBuck❔ If yes, remove |
phenning
approved these changes
Oct 12, 2022
Member
Author
|
I agree, let's merge this. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update project template precedence values
When .NET 6 and .NET 7 are installed side-by-side, some item templates cannot be created via
dotnet new. This PR fixes the issue by giving the 7.0 templates higher precedence.Description
Attempting to run
dotnet newusing one of the affected project templates (e.g. "page") results in the following error:The fix is to update the "precedence" values for each template to correlate with the major version (e.g.
700for .NET 7).Customer Impact
Without this fix, customers would not be able to use
dotnet newwith any of the templates defined inWeb.ItemTemplatesorWeb.Client.ItemTemplatesif .NET 6 and .NET 7 are installed side-by-side.Regression?
This is a new bug that occurs when .NET 6 and .NET 7 are installed side-by-side.
Risk
This PR changes a single value for each affected template configuration. We've already updated the precedence values for other templates and haven't seen any problems arise from that change.
Verification
Packaging changes reviewed?