Conversation
dougbu
left a comment
There was a problem hiding this comment.
Surprised I'm not getting code-mirror failure emails but agree this is necessary.
|
Any reason I shouldn't set auto-squish @BrennanConroy❔ |
|
Go for it |
|
Oddly, I can't for some reason. Thought I'd done this elsewhere in release/7.0 but maybe not… Same for you @wtgodbe❔ |
|
It looks like it'll let me Squash and merge without waiting for builds. There aren't any required pipelines for release/7.0 |
|
Ah, it was my bad. I changed the branch protection rules in order to clean up a couple of old branches. Forgot to reset protections |
|
Does this need to be backported to the rc1 branch @BrennanConroy❔ |
|
Why? That branch is temporary. Do we really care about CG alerts for it when we know they're going away soon? |
|
Given these are just suppressions and not real credential issues, I'm not worried about causing more churn in the rc1 branch for this. |
|
That comment can be interpreted either way 😆, yes or no to backporting to release/7.0-rc1? |
|
Sorry - no need to backport to release/7.0-rc1. |
Sorry it was an actual question, not a statement of a requirement. I was wondering if the files had been renamed in RC1 w/o this update because that would cause build breaks IIRC. |
|
The files were renamed in RC1, the suppressions have been updated in RC2 and main. What build breaks would not having the suppression cause? |
|
Not exactly "build breaks". The missing suppression should cause CredScan errors and issues filed against us and that we need to handle for RC1. If @Pilchie is fine dismissing the issues, we're good. |
Moved the certs to a shared location for other SignalR tests in another PR, forgot about this file.