Skip to content

Exclude some .wxl files from localization#43226

Merged
dougbu merged 2 commits intodotnet:mainfrom
dougbu:dougbu/exclude.some.wxl.files
Aug 12, 2022
Merged

Exclude some .wxl files from localization#43226
dougbu merged 2 commits intodotnet:mainfrom
dougbu:dougbu/exclude.some.wxl.files

Conversation

@dougbu
Copy link
Copy Markdown
Contributor

@dougbu dougbu commented Aug 11, 2022

@dougbu
Exclude some .wxl files from localization
5f172f6 
- preparing for dotnet/arcade#10383 merge and migration to this repo
- without this, `OneLocBuild` will generate multiple unused translation files
@dougbu dougbu requested a review from jonfortescue August 11, 2022 23:57
@dougbu dougbu requested review from a team and wtgodbe as code owners August 11, 2022 23:57
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 11, 2022
@dougbu
Copy link
Copy Markdown
Contributor Author

dougbu commented Aug 11, 2022

Oh, found an example LocExclusions.json file and the syntax is incorrect here. One moment...

jonfortescue
jonfortescue approved these changes Aug 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonfortescue jonfortescue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dougbu
Copy link
Copy Markdown
Contributor Author

dougbu commented Aug 12, 2022

@cristianosuzuki77 is there something I can do in source files like https://github.com/dotnet/aspnetcore/blob/main/src/Installers/Windows/SharedFrameworkBundle/thm.wxl to inform the loc team that most of the strings have existing translations❔ Might we worth including in this PR so we're ready.

I suggest validating what's already here of course.

@dougbu dougbu merged commit 0ec6416 into dotnet:main Aug 12, 2022
@dougbu dougbu deleted the dougbu/exclude.some.wxl.files branch August 12, 2022 05:31
@ghost ghost added this to the 7.0-rc1 milestone Aug 12, 2022
@dougbu
Copy link
Copy Markdown
Contributor Author

dougbu commented Aug 12, 2022

@cristianosuzuki77 is there something I can do in source files like https://github.com/dotnet/aspnetcore/blob/main/src/Installers/Windows/SharedFrameworkBundle/thm.wxl to inform the loc team that most of the strings have existing translations❔ Might we worth including in this PR so we're ready.

Will do this separately if it's possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

1 more reviewer

@jonfortescue jonfortescue jonfortescue approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

7.0-rc1

Development

Successfully merging this pull request may close these issues.

2 participants

@dougbu @jonfortescue