Add comment about QueryString in more places #43179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
approved these changes
Aug 10, 2022
adityamandaleeka
approved these changes
Aug 10, 2022
JamesNK
reviewed
Aug 10, 2022
| /// Includes <see cref="RequestProperties"/> and <see cref="RequestHeaders"/> | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// The HTTP Request <see cref="HttpRequest.QueryString"/> is not included with this flag as it may contain private information. |
Member
There was a problem hiding this comment.
It's weird to call this out as the reason why query string values are not here when headers are even more likely to contain private information (i.e. Authorize header)
Member
Author
There was a problem hiding this comment.
The default set of headers has also been audited to make sure it doesn't contain anything w/ private information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.