HTTP/3: Don't wait for writes to complete in sends #42683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityamandaleeka
approved these changes
Jul 28, 2022
7baca38 to
145f974
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #42289
There's no reason to wait for the client to indicate it has shutdown its side of the stream in theQuicStreamContext.DoSendsmethod.Won't be merged until the networking team figures out what is going on with the client not reporting it's done. This gives us a chance to still test that problem - dotnet/runtime#71927Talked with S.N.Q team more and DisposeAsync always awaits completion anyway. Remove this await is still worthwhile because we complete the output earlier.