Http Response fails when writing more than 255MB #41239
Conversation
|
One note about why Apparently, despite the documentation states that more than 65535 chunks will throw an exception, it seems that 65535 is the limit already. Also, there seems to be a problem when slicing a |
dougbu
left a comment
There was a problem hiding this comment.
Please remove the submodule updates from this PR
|
@dougbu sorry, missed that, hope it's fixed now |
| using Microsoft.AspNetCore.Server.IIS.FunctionalTests; | ||
| using Microsoft.AspNetCore.Testing; | ||
|
|
||
| namespace IIS.Tests; |
There was a problem hiding this comment.
@Tratcher is it worth running this test in any other functional permutations like IISExpress.Tests?
davidfowl
left a comment
There was a problem hiding this comment.
This isn't in the right layer, it should be closer to the call where the limit actually applies.
halter73
left a comment
There was a problem hiding this comment.
This looks really good. I only have minor feedback.
|
@sebastienros Do we have any benchmarks like plaintext or json that would verify we're not regressing IIS perf for normal response body writes without 65k+ memory chunks? |
|
I just updated some of the comments to use |
He is OOF and asked me to take this over.
No worries, appreciated. Thank you all for the help and the reviews. |
Http Response fails when writing more than 255MB
IISHttpContext.WriteBody now handles big buffers according to the limitation of IHttpResponse::WriteEntityChunks
by slicing the buffer and feeding a max of 65535 chunks per call to the native method.
Fixes #14191