[release/6.0] [blazor][debugger] Fixing vs-js-debugger: redirect ws to http is not supported anymore#39996
[release/6.0] [blazor][debugger] Fixing vs-js-debugger: redirect ws to http is not supported anymore#39996github-actions[bot] wants to merge 4 commits intorelease/6.0from
Conversation
Co-authored-by: Pranav K <prkrishn@hotmail.com>
|
Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
|
@lewing and I are working with the vs js debugger team to see whether the original dependency update on the VS side can be rolled back. If so, we don't have to rush this change in - as the Blazor WebAssembly debugging experience won't be broken so we won't need this change to be merged immediately. |
|
A change in the vs js debugger has been merged which makes the update be backward compatible. Given that I believe this PR should be closed now. @lewing do you agree? |
|
Also, @lewing, should this change be reverted? |
|
I don't think we need to service this now, but the change in main is still correct. I'm considering some related changes to propose that might remove the need for the other patch but I'll need some time before I can get to them. |
|
Hi @lewing. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Backport of #39995 to release/6.0
/cc @thaystg
{PR title}
Summary of the changes (Less than 80 chars)
Description
Fixes #{bug number} (in this specific format)
Customer Impact
Debugging Blazor wasm code in VS and VS Code will not function in new VS releases and previews.
Regression?
Changes in the upstream javascript debugger require this change for the wasm debugger to continue to function in VS and VS code
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
When servicing release/2.1