Skip to content

Update SPA submodule for RC1#35729

Merged
Pilchie merged 1 commit intorelease/6.0-rc1from
update-spa-submodule-rc1
Aug 26, 2021
Merged

Update SPA submodule for RC1#35729
Pilchie merged 1 commit intorelease/6.0-rc1from
update-spa-submodule-rc1

Conversation

@javiercn
Copy link
Member

@javiercn javiercn commented Aug 25, 2021

Customer Impact

Picks up the latest fixes on the dotnet/spa-templates repo approved for RC1.

  • Brings the templates inline with the rest of the ASP.NET templates that generate a random port for kestrel.
  • Updates the JavaScript dependencies to the latest available versions.

Testing

Manual testing

Risk

Low

@javiercn javiercn requested a review from Pilchie as a code owner August 25, 2021 19:12
@Pilchie
Copy link
Member

Pilchie commented Aug 25, 2021

Why did the lock files get so much bigger?

@javiercn
Copy link
Member Author

They changed format from V1 to V2 in previous versions of npm before 7.0. See here for details.

@Pilchie Pilchie added the Servicing-consider Shiproom approval is required for the issue label Aug 25, 2021
@ghost
Copy link

ghost commented Aug 25, 2021

Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge.

@leecow leecow added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Aug 26, 2021
@Pilchie Pilchie merged commit 75466b5 into release/6.0-rc1 Aug 26, 2021
@Pilchie Pilchie deleted the update-spa-submodule-rc1 branch August 26, 2021 18:05
@ghost ghost added this to the 6.0-rc1 milestone Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Servicing-approved Shiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants