JS root components for server and webview#34597
Merged
SteveSandersonMS merged 20 commits intomainfrom Jul 26, 2021
Merged
Conversation
5d61fbf to
6f545fe
Compare
591e378 to
c249913
Compare
66781cb to
557b100
Compare
…y with other platforms
…nd use it in sample
5da6c55 to
e02dc23
Compare
Member
Author
|
Updated and hopefully very done now. CC @aspnet-blazor-eng for review. |
|
Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:
|
campersau
reviewed
Jul 26, 2021
campersau
reviewed
Jul 26, 2021
Co-authored-by: campersau <buchholz.bastian@googlemail.com>
Co-authored-by: campersau <buchholz.bastian@googlemail.com>
shirhatti
reviewed
Jul 26, 2021
| services.AddServerSideBlazor(); | ||
| services.AddServerSideBlazor(options => | ||
| { | ||
| options.RootComponents.MaxJSRootComponents = 5; // To make it easier to test |
Contributor
There was a problem hiding this comment.
MaxJavaScriptRootComponentInstances
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for review. This is a mostly-simple extension of the new JS root components support to Server and WebView.
MaxJSRootComponentsis 100.IJSComponentConfigurationobject from its platform-specific "host builder" API so the developer can call the extension methods on it to set up the JS component config. As an example, here's how I added it to the Photino app model: d3bd7c3. Hopefully this will be a simple task. @Eilon, will you be able to add something equivalent to that for WebForms/WPF/MAUI in due course?