Skip to content

Remove System.ComponentModel.Annotations Dependency#32447

Closed
TanayParikh wants to merge 5 commits intomainfrom
taparik/removeComponentModelAnnotations
Closed

Remove System.ComponentModel.Annotations Dependency#32447
TanayParikh wants to merge 5 commits intomainfrom
taparik/removeComponentModelAnnotations

Conversation

@TanayParikh
Copy link
Contributor

No description provided.

@TanayParikh
Copy link
Contributor Author

/azp run


<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0' OR '$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'">
<Reference Include="System.ComponentModel.Annotations" />
<SuppressBaselineReference Include="System.ComponentModel.Annotations" /> <!-- suppress as a known breaking change -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change introduced.

@TanayParikh
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@TanayParikh
Copy link
Contributor Author

This dependency is still going to be required, moving to the non-auto-update section:

src/Identity/Extensions.Core/src/UserValidator.cs(6,29): error CS0234: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'DataAnnotations' does not exist in the namespace 'System.ComponentModel' (are you missing an assembly reference?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant