Skip to content

Changed default server for samples from IIS Express to Kestrel#29517

Merged
Tratcher merged 3 commits intodotnet:mainfrom
ShreyasJejurkar:kestrel-default
Jan 24, 2021
Merged

Changed default server for samples from IIS Express to Kestrel#29517
Tratcher merged 3 commits intodotnet:mainfrom
ShreyasJejurkar:kestrel-default

Conversation

@ShreyasJejurkar
Copy link
Contributor

@ShreyasJejurkar ShreyasJejurkar commented Jan 22, 2021 •
edited
Loading

Keeping kestrel as the first option, VS will automatically show as the default option selected for debugging! (If not, make sure you delete the .vs folder from the root of the cloned repo. )

I have kept some IIS servers test project launchSettings.json untouched because keeping IIS Express as the default option for them makes sense!

Fixes #27630

@javiercn
Copy link
Member

javiercn commented Jan 22, 2021

@MCCshreyas thanks for your contribution!

It looks great, the only comment I have is that I believe there might be missing projects that need this treatment, for example the ones in Blazor. Ideally we want to tackle all the projects in the repo in one go.

@Tratcher can you look at the ones in Server?

@javiercn javiercn added community-contribution Indicates that the PR has been added by a community member pr: pending author input For automation. Specifically separate from Needs: Author Feedback labels Jan 22, 2021
@ShreyasJejurkar
Copy link
Contributor Author

ShreyasJejurkar commented Jan 22, 2021

Sure @javiercn I will get those addressed in this PR only!

@ShreyasJejurkar ShreyasJejurkar requested review from a team and BrennanConroy as code owners January 22, 2021 11:57
Tratcher
Tratcher reviewed Jan 22, 2021
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The three projects under /src/Servers/HttpSys/samples/ (except TestClient) should also have a launchsettings that only includes the Project profile, no IIS.

@ShreyasJejurkar
Addressed PR feedback.
c03f580 
Removed IIS Settings from launchSettings and added launchSettings.json for HttpSys samples projects
@ShreyasJejurkar ShreyasJejurkar requested review from Tratcher and removed request for a team January 23, 2021 12:15
@Tratcher Tratcher merged commit 2e79de8 into dotnet:main Jan 24, 2021
@Tratcher Tratcher added this to the 6.0-preview1 milestone Jan 24, 2021
@Tratcher
Copy link
Member

Tratcher commented Jan 24, 2021

Thanks

@ghost
Copy link

ghost commented Jan 24, 2021

Hi @Tratcher. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@ShreyasJejurkar ShreyasJejurkar deleted the kestrel-default branch April 13, 2021 06:27
@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tratcher Tratcher Tratcher approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@javiercn javiercn Awaiting requested review from javiercn

@jkotalik jkotalik Awaiting requested review from jkotalik

@pranavkm pranavkm Awaiting requested review from pranavkm

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

Assignees

@Tratcher Tratcher

Labels

area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member pr: pending author input For automation. Specifically separate from Needs: Author Feedback

Projects

None yet

Milestone

6.0-preview1

Development

Successfully merging this pull request may close these issues.

Change default server for samples from IIS Express to Kestrel

5 participants

@ShreyasJejurkar @javiercn @Tratcher @Pilchie @amcasey