Avoid expensive work for CertificateManager logging when not enabled#27956
Merged
1 commit merged intodotnet:masterfrom Nov 23, 2020
Merged
Avoid expensive work for CertificateManager logging when not enabled#279561 commit merged intodotnet:masterfrom
1 commit merged intodotnet:masterfrom
Conversation
davidfowl
approved these changes
Nov 18, 2020
|
Hello @davidfowl! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This was referenced Jan 22, 2021
5 tasks
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of calls to CertificateManager.Log.SomeEvent are made but with computed arguments that are relatively expensive. These should all be guarded behind IsEnabled checks to only do that work if the logging is likely to happen.
Related to dotnet/runtime#44598