Merged
Conversation
campersau
reviewed
Aug 23, 2019
| this.button.style.display = 'block'; | ||
| this.reloadParagraph.style.display = 'none'; | ||
| this.message.innerHTML = 'Reconnection failed. Try <a href>reloading</a> the page if you\'re unable to reconnect.'; | ||
| this.message.querySelector('a')!.addEventListener('click', () => location.reload()); |
Contributor
There was a problem hiding this comment.
Maybe also add e.preventDefault().
Because location.reload() also keeps the url fragment # whereas just the href does not.
Member
Author
There was a problem hiding this comment.
We want to keep the whole URL. The href is not involved because normal navigation can't occur while disconnected.
javiercn
approved these changes
Aug 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains fixes for #13331, #13370, #13371, #13374, and #13375, all of which are regressions in preview 9.
Each of the commits in this PR could be used independently to fix particular issues if needed.
Let's discuss in triage today whether this is realistic to include in preview 9 or 3.0.