[Blazor] Enables the client to initiate blazor server-side renders by javiercn · Pull Request #13147 · dotnet/aspnetcore

javiercn · 2019-08-14T22:52:23Z

Remove the need to register components.
Removes all overloads of MapComponentHub that takes a component type.
Adds a RenderMode to define how to render a component.
- HTML: Renders the component as static HTML.
- Server: Renders a placeholder for the component so that the client can start a blazor application.
- ServerPrerender: Prerenders the component and includes a marker before an after so that a blazor application can be started.

Fixes #12795

src/Components/Server/src/ComponentHub.cs

src/Components/Server/ref/Microsoft.AspNetCore.Components.Server.netcoreapp3.0.cs

src/Components/Server/src/Circuits/DefaultCircuitFactory.cs

src/Components/Server/src/Circuits/RemoteRenderer.cs

src/Components/Server/src/ComponentHub.cs

src/Components/Server/src/Microsoft.AspNetCore.Components.Server.csproj

src/Components/Web.JS/src/Boot.Server.ts

src/Components/Web.JS/src/Platform/Circuits/CircuitManager.ts

src/Components/Web.JS/src/Rendering/LogicalElements.ts

src/Components/test/testassets/ComponentsApp.Server/Pages/_Host.cshtml

src/Mvc/Mvc.ViewFeatures/src/HtmlHelperComponentExtensions.cs

src/Mvc/Mvc.ViewFeatures/src/Infrastructure/ComponentHtmlContent.cs

src/Mvc/Mvc.ViewFeatures/src/Microsoft.AspNetCore.Mvc.ViewFeatures.csproj

src/Mvc/Mvc.ViewFeatures/src/RenderMode.cs

src/Shared/Components/ComponentDescriptorInstance.cs

src/Shared/Components/ComponentDescriptorSerializer.Deserialize.cs

src/Components/test/testassets/TestServer/Pages/_ServerHost.cshtml

src/Components/test/testassets/TestServer/Startup.cs

src/Mvc/Mvc.ViewFeatures/ref/Microsoft.AspNetCore.Mvc.ViewFeatures.netcoreapp3.0.cs

src/Mvc/Mvc.ViewFeatures/src/HtmlHelperComponentExtensions.cs

src/Mvc/Mvc.ViewFeatures/src/ServerComponentSerializer.cs

rynowak

I've given this a look, and I'm fairly happy with what I'm seeing in the product code.

I don't really get what's going on with some of these test changes, and I think it deserves more dicussion.

rynowak · 2019-08-16T04:04:31Z

I also want to know if we can find a better way than relying on HttpContext.Items.

src/Shared/Components/ServerComponent.cs

src/Shared/Components/ServerComponentMarker.cs

rynowak

We discussed offline about the test changes here, and why changing something is necessary. Basically since it's no longer possible to host server-side components in static HTML we haven't change how the server-side tests work.

@javiercn - has some ideas about what we should do here to try to and make this simpler in the future. Right now what's here isn't great - there are like 3 different strategies in use. He's going to follow up after we close down preview 9.

* Removes all overloads that register a component statically with aborts selector. * Updates render component to have a RenderMode parameter that indicates how the component must render. Valid values are Static, Server, and ServerPrerendered. * When using Server or ServerPrerendered we emit marker comments into the page that are later used by blazor.server.js to bootrstrap a blazor server-side application.

javiercn requested a review from SteveSandersonMS as a code owner August 14, 2019 22:52

javiercn requested review from rynowak and removed request for SteveSandersonMS August 14, 2019 22:52

javiercn commented Aug 14, 2019

View reviewed changes

src/Components/Server/src/ComponentHub.cs Outdated Show resolved Hide resolved

javiercn commented Aug 14, 2019

View reviewed changes

src/Components/Server/src/ComponentHub.cs Outdated Show resolved Hide resolved

javiercn force-pushed the javiercn/blazor-multiple-component-entry-points branch from 236bc70 to dce881e Compare August 14, 2019 23:49