-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Obsolete IPNetwork #46157
Copy link
Copy link
Closed
Labels
api-approvedAPI was approved in API review, it can be implementedAPI was approved in API review, it can be implementedarea-networkingIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractionsIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Milestone
Description
Metadata
Metadata
Assignees
Labels
api-approvedAPI was approved in API review, it can be implementedAPI was approved in API review, it can be implementedarea-networkingIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractionsIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Type
Fields
Give feedbackNo fields configured for issues without a type.
The BCL is planning a replacement for this type: dotnet/runtime#79946
We should consume theirs when available and obsolete ours.
aspnetcore/src/Middleware/HttpOverrides/src/IPNetwork.cs
Line 13 in 83d6c56
aspnetcore/src/Middleware/HttpOverrides/src/ForwardedHeadersOptions.cs
Line 73 in 83d6c56
Consider adding an implicit converter to minimize the breaking changes in the short term.
Proposed API
namespace Microsoft.AspNetCore.Builder; public class ForwardedHeadersOptions { + [Obsolete(...)] public IList<Microsoft.AspNetCore.HttpOverrides.IPNetwork> KnownNetworks { get; } + public IList<System.Net.IPNetwork> KnownIPNetworks { get; } }