Ensure all grid columns have tooltips#9401
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that all grid columns display tooltips by updating the AspireTemplateColumn and AspirePropertyColumn components to set the Tooltip property to true during initialization.
- Sets Tooltip = true in the OnInitialized() method for both column classes
- Addresses the missing tooltip issue in specific grid columns
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Aspire.Dashboard/Components/Controls/Grid/AspireTemplateColumn.cs | Added OnInitialized override to set Tooltip = true |
| src/Aspire.Dashboard/Components/Controls/Grid/AspirePropertyColumn.cs | Added OnInitialized override to set Tooltip = true |
| [Parameter] | ||
| public string? ColumnId { get; set; } | ||
|
|
||
| protected override void OnInitialized() |
There was a problem hiding this comment.
Both AspireTemplateColumn and AspirePropertyColumn set Tooltip = true in their OnInitialized methods. Consider refactoring this shared behavior into a common base class to reduce duplicate code and ease future maintenance.
| [Parameter] | ||
| public string? ColumnId { get; set; } | ||
|
|
||
| protected override void OnInitialized() |
There was a problem hiding this comment.
Both AspireTemplateColumn and AspirePropertyColumn set Tooltip = true in their OnInitialized methods. Consider refactoring this shared behavior into a common base class to reduce duplicate code and ease future maintenance.
Description
Ensure that all columns have tooltips. Since we use AspireTemplateColumn/AspirePropertyColumn everywhere, we can just set this property. This issue was only affecting certain columns.
After:
Before:
(no tooltip)
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate