Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses #9368 by improving error handling for JSON parsing in the DotNetCliRunner. Key changes include wrapping the JSON parse call in a try...catch block, logging a clear error message when parsing fails, and returning an appropriate error code.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #9368 by adding error handling around JSON parsing of package search results to prevent stack traces from being dumped.
- Wraps JSON parsing logic in a try-catch block
- Logs a concise error message and returns a specific exit code on JSON errors
sebastienros
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #9368
Philosophically perhaps this should go in the dotnet CLI which shouldn't dump this stack.
Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate