Remove the workaround to explicitly set the container runtime for tests now that the orchestrator is updated#9339
Merged
karolz-ms merged 1 commit intodotnet:mainfrom May 15, 2025
Conversation
…cker info (dotnet#9200)" This reverts commit 8692e43.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes an outdated workaround for explicitly setting the container runtime in test environments, as the orchestrator update now supports autodetection.
- Removed the forced container runtime command from the Helix test project.
- Removed the environment variable overrides from the BuildAndTest pipeline and GitHub workflows.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/helix/send-to-helix-inner.proj | Removed the explicit container runtime setting and its comment |
| eng/pipelines/templates/BuildAndTest.yml | Removed the container runtime environment variable override |
| .github/workflows/run-tests.yml | Removed the container runtime environment variable override from multiple job definitions |
Comments suppressed due to low confidence (4)
tests/helix/send-to-helix-inner.proj:155
- Removal of the explicit container runtime setting is correct given the orchestrator update. Please verify that tests in environments relying on autodetection behave as expected.
<!-- Force container runtime to Docker since that's what is installed on Helix -->
eng/pipelines/templates/BuildAndTest.yml:108
- The removal of the forced container runtime in the pipeline environment variables is aligned with the updated orchestrator behavior. Consider confirming that the build and test scripts work correctly across all supported platforms.
DOTNET_ASPIRE_CONTAINER_RUNTIME: docker
.github/workflows/run-tests.yml:215
- Consistent removal of the container runtime override from the workflow is appropriate with the orchestrator update. Ensure that the workflow tests remain stable without this variable.
DOTNET_ASPIRE_CONTAINER_RUNTIME: docker
.github/workflows/run-tests.yml:237
- The removal of the runtime override in this job is consistent with the intended changes. Confirm that no dependency on the explicit variable exists in any downstream steps.
DOTNET_ASPIRE_CONTAINER_RUNTIME: docker
karolz-ms
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent orchestrator update changed how we autodetect container runtimes, so the workaround of forcing the runtime should no longer be necessary.