Revert "Revert "Update xUnit.v3 to support MTP tests (#9261)" (#9336)"#9337
Merged
danmoseley merged 1 commit intodotnet:mainfrom May 15, 2025
Merged
Revert "Revert "Update xUnit.v3 to support MTP tests (#9261)" (#9336)"#9337danmoseley merged 1 commit intodotnet:mainfrom
danmoseley merged 1 commit intodotnet:mainfrom
Conversation
…otnet#9336)" The earlier revert was incorrect. That wasn't commit responsible for breaking the build. It was: ``` commit 6ca2de9 Author: Ankit Jain <radical@gmail.com> Date: Wed May 14 11:39:18 2025 -0400 [CI] Add PR validation on macOS (dotnet#9287) ``` This reverts commit 3850afa.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR re-reverts a previous revert to reapply the xUnit.v3 updates required for MTP tests.
- Reapplies changes by reverting commit 3850afa.
- Updates dependency versions in eng/Versions.props.
- Adjusts VS Code settings in .vscode/settings.json to enable testing using the Testing Platform Protocol.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/Versions.props | Bumps xUnit V3, XUnitAnalyzers, and XunitRunnerVisualStudio versions accordingly. |
| .vscode/settings.json | Enables the Testing Platform Protocol by changing dotnet.testWindow.useTestingPlatformProtocol from false to true. |
danmoseley
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The earlier revert was incorrect. That wasn't commit responsible for breaking the build. It was:
This reverts commit 3850afa.